Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] operator edit option to require signing keys in operator jwt #352

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

matthiashanel
Copy link
Contributor

If on edit, accounts or users violating this rule exist the operation
fails.
Also generating system account with a signing key

Signed-off-by: Matthias Hanel mh@synadia.com

@matthiashanel matthiashanel requested a review from aricart January 26, 2021 01:11
[added] option to sign system account with operator signing key
If on edit, accounts or users violating this rule exist the operation
fails.
Also generate system account with a signing key.

Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The option require-signing-keys requires subordinate objects to be
signed by signing keys only.
In this mode identity keys are not suggested for signing.

Where the option --sk (for signing key) can be used, the value
"generate" causes a signing key to be generated/stored on the fly"

Updated jwt library

Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthiashanel matthiashanel merged commit f4662e9 into master Jan 29, 2021
@matthiashanel matthiashanel deleted the require-sk branch January 29, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants